Complete syntax sugar for createSchemaTemplate#3407
Complete syntax sugar for createSchemaTemplate#3407bigreybear wants to merge 17 commits intoapache:masterfrom bigreybear:master
Conversation
|
Any api javaDoc? |
There was a problem hiding this comment.
I got the design doc.
void createSchemaTemplate(
String templateName,
List<IMeasurementSchema>
)
VectorMeasurementSchema(String prefixPath, List<String> measurementNames, List<TSDataType> datatypes, List<TSEncoding> encodings)
MeasurementSchema(Sting path, TSDatatype datatype, TSEncoding encoding)
I think you may misunderstand the purpose of this PR.
What you should do in this PR is creating only one new interface createSchemaTemplate.
The IMeasurementSchema is an interface that could be a VectorMeasurementSchema or a MeasurementSchema.
VectorMeasurementSchema(String prefixPath, List<String> measurementNames, List<TSDataType> datatypes, List<TSEncoding> encodings) and MeasurementSchema(Sting path, TSDatatype datatype, TSEncoding encoding) are trying to tell you what informations are in these classes.
You cannot use the singletonList for datatypes and encodings directly.
HTHou
left a comment
There was a problem hiding this comment.
Almost good to me.
I think we can also add a usage example in alignedTimeseriesSessionExample.
No description provided.