Fix sonar by Yanzhe An#38
Merged
jixuan1989 merged 6 commits intoapache:masterfrom Feb 16, 2019
SolomonAnn:master
Merged
Conversation
LeiRui
reviewed
Jan 30, 2019
iotdb-cli/src/main/java/org/apache/iotdb/cli/client/AbstractClient.java
Outdated
Show resolved
Hide resolved
liuruiyiyang
requested changes
Feb 1, 2019
Contributor
liuruiyiyang
left a comment
liuruiyiyang
left a comment
There was a problem hiding this comment.
I suggest that you take a look at how LOGGER is used in other classes and use it a uniform way instead of simply copying the string in System.out.println() to the LOGGER.error(), etc.
iotdb-cli/src/main/java/org/apache/iotdb/cli/tool/ExportCsv.java
Outdated
Show resolved
Hide resolved
iotdb-cli/src/main/java/org/apache/iotdb/cli/tool/ExportCsv.java
Outdated
Show resolved
Hide resolved
iotdb-cli/src/main/java/org/apache/iotdb/cli/tool/ExportCsv.java
Outdated
Show resolved
Hide resolved
iotdb-cli/src/main/java/org/apache/iotdb/cli/tool/ImportCsv.java
Outdated
Show resolved
Hide resolved
iotdb-cli/src/main/java/org/apache/iotdb/cli/tool/ImportCsv.java
Outdated
Show resolved
Hide resolved
iotdb-cli/src/main/java/org/apache/iotdb/cli/tool/ImportCsv.java
Outdated
Show resolved
Hide resolved
iotdb-cli/src/main/java/org/apache/iotdb/cli/tool/ImportCsv.java
Outdated
Show resolved
Hide resolved
iotdb-cli/src/main/java/org/apache/iotdb/cli/tool/ImportCsv.java
Outdated
Show resolved
Hide resolved
Contributor
|
ImportCsv.java, ExportCsv.java, etc. these classes are for command-line interface, should they use System.out.println() instead of LOGGER? @MyXOF @SolomonAnn |
jixuan1989
reviewed
Feb 11, 2019
iotdb-cli/src/main/java/org/apache/iotdb/cli/tool/ExportCsv.java
Outdated
Show resolved
Hide resolved
Member
|
please solve the conflict with the master branch |
neuyilan
added a commit
to neuyilan/iotdb
that referenced
this pull request
Jun 21, 2021
Merge master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.