[ISSUE-3856] refine exception handling logic in commitTo in Raft…#3848
Merged
OneSizeFitsQuorum merged 2 commits intoapache:masterfrom Sep 7, 2021
Merged
Conversation
OneSizeFitsQuorum
approved these changes
Sep 2, 2021
Contributor
OneSizeFitsQuorum
left a comment
OneSizeFitsQuorum
left a comment
There was a problem hiding this comment.
LGTM~
Please fix grammer errors.
neuyilan
approved these changes
Sep 2, 2021
HTHou
changed the title
cigarl
pushed a commit
to cigarl/iotdb
that referenced
this pull request
Sep 30, 2021
…ache#3848) * [discussion-3833] refine exception handling logic in commitTo in RaftLogManager * fix grammer error Co-authored-by: chengjianyun <chengjianyun@360.cn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea come from the discussion: #3833
Here I want to refine the error handling logic in
commitToto make cluster more robust and make code a bit more clear.The idea here is don't let Raft group run into a invalid state when some error happened from Raft log persistence. And refine try catch block make the code clean.