Skip to content

[IOTDB-1716] Remove TEMPORARY keyword from CREATE FUNCTION statement#4004

Merged
SteveYurongSu merged 2 commits intoapache:masterfrom
ericpai:bugfix/iotdb-1716
Sep 22, 2021
Merged

[IOTDB-1716] Remove TEMPORARY keyword from CREATE FUNCTION statement#4004
SteveYurongSu merged 2 commits intoapache:masterfrom
ericpai:bugfix/iotdb-1716

Conversation

@ericpai
Copy link
Copy Markdown
Member

@ericpai ericpai commented Sep 21, 2021

See JIRA https://issues.apache.org/jira/browse/IOTDB-1716. The TEMPORARY keyword will be removed.

@ericpai ericpai force-pushed the bugfix/iotdb-1716 branch 2 times, most recently from 0513a5b to 52a078f Compare September 21, 2021 07:48
@ericpai ericpai marked this pull request as ready for review September 21, 2021 10:15
@ericpai
Copy link
Copy Markdown
Member Author

ericpai commented Sep 21, 2021

@SteveYurongSu This PR is ready for reviewing, thanks.

@HTHou HTHou requested a review from SteveYurongSu September 21, 2021 14:06
@SteveYurongSu
Copy link
Copy Markdown
Member

@SteveYurongSu This PR is ready for reviewing, thanks.

Thanks for your contribution. I will check it ASAP :D

@SteveYurongSu SteveYurongSu changed the title Remove TEMPORARY keyword [IOTDB-1716] Remove TEMPORARY keyword from CREATE FUNCTION statement Sep 22, 2021
@SteveYurongSu
Copy link
Copy Markdown
Member

Disscusion: #3992

Copy link
Copy Markdown
Member

@SteveYurongSu SteveYurongSu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SteveYurongSu SteveYurongSu merged commit d13523b into apache:master Sep 22, 2021
@ericpai ericpai deleted the bugfix/iotdb-1716 branch September 22, 2021 02:03
cigarl pushed a commit to cigarl/iotdb that referenced this pull request Sep 30, 2021
…ent (apache#4004)

* Remove TEMPORARY keyword

* Fix test cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants