Skip to content

fix NPE when header node is non-existent.#4089

Merged
OneSizeFitsQuorum merged 2 commits intoapache:masterfrom
cigarl:rmv-fix
Oct 12, 2021
Merged

fix NPE when header node is non-existent.#4089
OneSizeFitsQuorum merged 2 commits intoapache:masterfrom
cigarl:rmv-fix

Conversation

@cigarl
Copy link
Copy Markdown
Contributor

@cigarl cigarl commented Oct 8, 2021

When we remove a node from cluster,partition table could be updated before pullSnapshot.That means the header node in raft groups could be non-existent when try to pullSnapshot.We need to handle the exception.

Copy link
Copy Markdown
Member

@wangchao316 wangchao316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@neuyilan neuyilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neuyilan neuyilan added 0.12.3 Module - Cluster PRs for the cluster module labels Oct 11, 2021
@mychaow mychaow removed the 0.12.3 label Oct 11, 2021
Copy link
Copy Markdown
Contributor

@OneSizeFitsQuorum OneSizeFitsQuorum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OneSizeFitsQuorum OneSizeFitsQuorum merged commit df3c3f5 into apache:master Oct 12, 2021
@cigarl cigarl deleted the rmv-fix branch October 20, 2021 08:39
cornmonster pushed a commit to cornmonster/iotdb that referenced this pull request Oct 25, 2021
* fix NPE when header node is non-existent.

* adjust the log level
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module - Cluster PRs for the cluster module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants