[IOTDB-239] Add interface for showing devices #421
Conversation
| /** | ||
| * Get all devices in current Metadata Tree. | ||
| * | ||
| * @return a list contains all distinct storage groups |
There was a problem hiding this comment.
| * @return a list contains all distinct storage groups | |
| * @return a list contains all distinct devices |
| * @return a list contains all distinct storage groups | ||
| */ | ||
| HashSet<String> getAllDevices() { | ||
| return new HashSet<>(getNodesList("3")); |
There was a problem hiding this comment.
getNodesList method is implemented before and I just call it here, should I change the param type to int? (which I think is better as well)
| } | ||
| case "SHOW_DEVICES": | ||
| Set<String> devices = getAllDevices(); | ||
| resp.setShowDevices(devices); |
There was a problem hiding this comment.
| resp.setShowDevices(devices); | |
| resp.setDevices(devices); |
There was a problem hiding this comment.
Here I also keep consistent with SHOW TIMESERIES and SHOW STORAGE GROUP interface, in which they uses setShowTimeseriesList and setShowStorageGroups... Should I change all of these interfaces? (and I also think your suggestion is better...)
| } | ||
| Assert.assertEquals(resultStr.toString(), standard); | ||
| } catch (SQLException e) { | ||
| System.out.println(e); |
There was a problem hiding this comment.
Simply print out the exception may bury the error and the TestCase will be regarded as PASSED. It's better to replace it with e.printStackTrace(); fail(e.getMessage());.
| return mtree.getAllStorageGroup(); | ||
| } | ||
|
|
||
| HashSet<String> getAllDevices() { |
There was a problem hiding this comment.
I note that all its callers Interprete the returned value as Set but not HashSet.
|
Hi @qiaojialin @kr11 , Thanks a lot for your detailed review! I have updated codes as you suggested. |
3 participants
Create an interface for showing all the devices.
USAGE:
SHOW DEVICES.