[To new_vector] Add MeasurementPath and Refactor groupVectorPath#4268
Merged
qiaojialin merged 20 commits intoapache:new_vectorfrom Oct 31, 2021
Merged
[To new_vector] Add MeasurementPath and Refactor groupVectorPath#4268qiaojialin merged 20 commits intoapache:new_vectorfrom
qiaojialin merged 20 commits intoapache:new_vectorfrom
Conversation
…adata_new_vector � Conflicts: � server/src/main/java/org/apache/iotdb/db/metadata/MManager.java � server/src/main/java/org/apache/iotdb/db/metadata/mnode/MeasurementMNode.java � server/src/main/java/org/apache/iotdb/db/metadata/mtree/MTree.java
This reverts commit d24f6a5.
…adata_new_vector � Conflicts: � server/src/main/java/org/apache/iotdb/db/engine/memtable/VectorWritableMemChunk.java
qiaojialin
reviewed
Oct 31, 2021
| schemaList.add(path.getMeasurementSchema()); | ||
| } | ||
|
|
||
| public List<String> getSubSensorsList() { |
Member
There was a problem hiding this comment.
Suggested change
| public List<String> getSubSensorsList() { | |
| public List<String> getMeasurementList() { |
| // todo improve vector implementation by remove this placeholder | ||
| private static final String VECTOR_PLACEHOLDER = ""; | ||
|
|
||
| private List<String> subSensorsList; |
Member
There was a problem hiding this comment.
Suggested change
| private List<String> subSensorsList; | |
| private List<String> measurementList; |
| @@ -34,7 +39,11 @@ | |||
| */ | |||
| public class VectorPartialPath extends PartialPath { | |||
Member
There was a problem hiding this comment.
Suggested change
| public class VectorPartialPath extends PartialPath { | |
| public class AlignedPaths extends PartialPath { |
| @Override | ||
| public MeasurementPath getPartialPath() { | ||
| MeasurementPath result = new MeasurementPath(super.getPartialPath()); | ||
| // result.setMeasurementAlias(alias); |
| IEntityMNode getParent(); | ||
|
|
||
| @Override | ||
| MeasurementPath getPartialPath(); |
Member
There was a problem hiding this comment.
Suggested change
| MeasurementPath getPartialPath(); | |
| MeasurementPath getMeasurementPath(); |
| } | ||
|
|
||
| @Override | ||
| public PartialPath getExactPath() { |
Contributor
Author
There was a problem hiding this comment.
If the partialPath is AlignedPath and it has only one measurement, return the measurement's PartialPath. Otherwise, return this partialPath.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description