Skip to content

[IOTDB-1935] Aligned timeseries support deleting#4454

Merged
JackieTien97 merged 12 commits intomasterfrom
delete_aligned
Nov 30, 2021
Merged

[IOTDB-1935] Aligned timeseries support deleting#4454
JackieTien97 merged 12 commits intomasterfrom
delete_aligned

Conversation

@HTHou
Copy link
Copy Markdown
Contributor

@HTHou HTHou commented Nov 23, 2021

Description

Support delete column by the following sql statements:

insert into root.sg.d2(time, s1, s2) aligned values(1, 1, 2)
insert into root.sg.d2(time, s1, s2) aligned values(2, 1, 2)

delete timeseries root.sg.d2.s2 where time <= 1
delete timeseries root.sg.d2.s1


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

@coveralls
Copy link
Copy Markdown

coveralls commented Nov 23, 2021

Coverage Status

Coverage increased (+0.04%) to 67.34% when pulling 77017d6 on delete_aligned into 3c3c523 on master.

@HTHou HTHou marked this pull request as draft November 26, 2021 04:06
@HTHou HTHou marked this pull request as ready for review November 29, 2021 02:29
@HTHou HTHou changed the title [IOTDB-1935] Aligned timeseries support deleting one column [IOTDB-1935] Aligned timeseries support deleting Nov 29, 2021
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

92.1% 92.1% Coverage
0.0% 0.0% Duplication

@JackieTien97 JackieTien97 merged commit 3d48a88 into master Nov 30, 2021
@JackieTien97 JackieTien97 deleted the delete_aligned branch November 30, 2021 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants