[IOTDB-1899] Fix stream closed exception during compaction#4457
Merged
qiaojialin merged 12 commits intoapache:masterfrom Nov 27, 2021
Merged
[IOTDB-1899] Fix stream closed exception during compaction#4457qiaojialin merged 12 commits intoapache:masterfrom
qiaojialin merged 12 commits intoapache:masterfrom
Conversation
qiaojialin
reviewed
Nov 26, 2021
server/src/main/java/org/apache/iotdb/db/engine/compaction/CompactionTaskManager.java
Outdated
Show resolved
Hide resolved
qiaojialin
approved these changes
Nov 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the process of IoTDB running, the compaction thread sometimes throws
IOException: Stream Closed.Cause
Before the compaction task is executed, it will be temporarily stored in the cache queue of the CompactionTaskManager. Before joining the compaction queue, we will judge whether there are the same compaction tasks in the queue to avoid duplication. But if a task is being executed in the thread pool, at this time an identical compaction task may be allowed to be submitted to the queue (because the same task does not exist in the queue). Therefore, a compaction task may be executed at the same time.