Merged
Conversation
wangchao316
requested changes
Jan 19, 2022
| try { | ||
| IDiskSchemaManager.recover(this); | ||
| } catch (IOException e) { | ||
| logger.error("can't recover id table of " + storageGroupDir.getName()); |
wangchao316
reviewed
Jan 19, 2022
|
|
||
| @Override | ||
| public void recover(IDTable idTable) throws IOException { | ||
| FileInputStream inputStream = new FileInputStream(dataFile); |
Member
There was a problem hiding this comment.
stream should try(), or close in finally.
|
SonarCloud Quality Gate failed. |
xinzhongtianxia
pushed a commit
to xinzhongtianxia/iotdb
that referenced
this pull request
Jan 23, 2022
…ubernetes_helm * remotes/upstream/master: (76 commits) [IOTDB-2468][Compaction]There is 'null' in logs (apache#4958) [IOTDB-2464] simplify crossSpaceComapctionExceptionHandler (apache#4945) [DOC] Update auto create metadata docs (apache#4955) [IOTDB-2338] ID Table recovery (apache#4897) [IOTDB-2373][Trigger] MQTTSink: there should be a timeout rule (apache#4953) [IOTDB-2462] Fix ALIGN BY DEVICE query in cluster mode (apache#4947) [IOTDB-2465][imple] fix implement of snapshot of dropwizard to UniformReservoir [IOTDB-2463] Fix snapshot compatibility (apache#4951) fix spotless [IOTDB-2281][IOTDB-2286] fix bugs of csv tools (apache#4941) [IOTDB-2425][env] rename IOTDB_CLI_HOME to IOTDB_HOME in CLI (apache#4949) Revert "[env] rename IOTDB_CLI_HOME to IOTDB_HOME (apache#4944)" (apache#4948) [env] rename IOTDB_CLI_HOME to IOTDB_HOME (apache#4944) [IOTDB-2453] Set the default compaction priority to `BALANCE` (apache#4938) Fix compile error (apache#4943) [IOTDB-2380] add show schema interface for show measurements in template (apache#4940) [IOTDB-2460] Fix NoSuchFileException while querying and ttl happened same time (apache#4937) [IOTDB-2457] Fix Write is blocked after set time_index_level=FILE_TIM… (apache#4935) [IOTDB-2444] Refine /ping API and fix unauthorized NPE error (apache#4910) [IOTDB-2362] [REST API] Use noQuery to execute "count", return "SHOW is not supported" (apache#4933) ... # Conflicts: # pom.xml # site/src/main/.vuepress/config.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implement id table recovery logic. After this PR, id table can recover from it's log without mlog.
Design doc: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=195727793
JIRA: https://issues.apache.org/jira/browse/IOTDB-2338
This PR has:
for an unfamiliar reader.
for code coverage.