Skip to content

[IOTDB-2512]Replaced some static variables with TSDataType.toString#5018

Merged
HTHou merged 3 commits intoapache:masterfrom
JerryZhangZZY:IOTDB-2512
Feb 8, 2022
Merged

[IOTDB-2512]Replaced some static variables with TSDataType.toString#5018
HTHou merged 3 commits intoapache:masterfrom
JerryZhangZZY:IOTDB-2512

Conversation

@JerryZhangZZY
Copy link
Contributor

Replaced Boolean, Double and Float with TSDataType.toString in those 3 classes respectively.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, this is your first pull request in IoTDB project. Thanks for your contribution! IoTDB will be better because of you.

@JerryZhangZZY JerryZhangZZY changed the title [IOTDB-2512]fix [IOTDB-2512]Replaced static variables with TSDataType.toString Feb 8, 2022
@JerryZhangZZY JerryZhangZZY changed the title [IOTDB-2512]Replaced static variables with TSDataType.toString [IOTDB-2512]Replaced some static variables with TSDataType.toString Feb 8, 2022
@coveralls
Copy link

coveralls commented Feb 8, 2022

Coverage Status

Coverage increased (+0.04%) to 67.783% when pulling 26e3e00 on JerryZhangZZY:IOTDB-2512 into 5767587 on apache:master.

Copy link
Contributor

@HTHou HTHou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HTHou HTHou merged commit 9c97d09 into apache:master Feb 8, 2022
@JerryZhangZZY JerryZhangZZY deleted the IOTDB-2512 branch February 9, 2022 07:06
@hoho1221
Copy link

hoho1221 commented Feb 9, 2022

why not just remove abstract for these methods in Statistics class, and add default implementations throw StatisticsClassException(String.format(STATS_UNSUPPORTED_MSG, getType(), "***"))

@JerryZhangZZY
Copy link
Contributor Author

JerryZhangZZY commented Feb 10, 2022 via email

jun0315 pushed a commit to jun0315/iotdb that referenced this pull request Feb 22, 2022
…pache#5018)

Co-authored-by: Zhang Zeyu <JerryZhang20010417@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants