[IOTDB-2512]Replaced some static variables with TSDataType.toString#5018
Merged
HTHou merged 3 commits intoapache:masterfrom Feb 8, 2022
JerryZhangZZY:IOTDB-2512
Merged
[IOTDB-2512]Replaced some static variables with TSDataType.toString#5018HTHou merged 3 commits intoapache:masterfrom JerryZhangZZY:IOTDB-2512
HTHou merged 3 commits intoapache:masterfrom
JerryZhangZZY:IOTDB-2512
Conversation
|
Coverage increased (+0.04%) to 67.783% when pulling 26e3e00 on JerryZhangZZY:IOTDB-2512 into 5767587 on apache:master. |
|
why not just remove |
Contributor
Author
|
Good idea, thanks for your suggestion!
从 Windows 版邮件发送
发件人: Changqi
发送时间: 2022年2月9日 下午 5:41
收件人: apache/iotdb
抄送: Zhang Zeyu; State change
主题: Re: [apache/iotdb] [IOTDB-2512]Replaced some static variables withTSDataType.toString (PR #5018)
why not just remove abstract for these methods in Statistics class, and add default implementations throw StatisticsClassException(String.format(STATS_UNSUPPORTED_MSG, getType(), "***"))
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
jun0315
pushed a commit
to jun0315/iotdb
that referenced
this pull request
Feb 22, 2022
…pache#5018) Co-authored-by: Zhang Zeyu <JerryZhang20010417@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced Boolean, Double and Float with TSDataType.toString in those 3 classes respectively.