[IOTDB-2750] Enhance check statement before writing mlog#5253
Merged
HTHou merged 1 commit intoapache:masterfrom Mar 16, 2022
Merged
[IOTDB-2750] Enhance check statement before writing mlog#5253HTHou merged 1 commit intoapache:masterfrom
HTHou merged 1 commit intoapache:masterfrom
Conversation
HTHou
changed the title
qiaojialin
approved these changes
Mar 16, 2022
HTHou
approved these changes
Mar 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason of the ISSUE:
During recovery from mlog.bin, MManager::MLogWrite is not initialized since there is no need to write a new entry into mlog, which directly causes the NPE of this issue. This may be caused by nonstandard usage of Templates or originate from disharmonious implementation between MManager and TemplateManager. We will make a thorough refactor to these modules soon.
To fix this issue, we enhanced the check statement before writing entry into mlog.