[IOTDB-2754] SessionPool auto redirect IoTDB instance#5267
[IOTDB-2754] SessionPool auto redirect IoTDB instance#5267qiaojialin merged 5 commits intoapache:masterfrom
Conversation
SilverNarcissus
left a comment
SilverNarcissus
left a comment
There was a problem hiding this comment.
Nice work! We also need some test for this new session pool, could you please add some IT?
example/session/src/main/java/org/apache/iotdb/SessionPoolExample.java
Outdated
Show resolved
Hide resolved
OneSizeFitsQuorum
left a comment
OneSizeFitsQuorum
left a comment
There was a problem hiding this comment.
LGTM. Only minor issue. PTAL
example/session/src/main/java/org/apache/iotdb/SessionPoolExample.java
Outdated
Show resolved
Hide resolved
| Config.DEFAULT_CONNECTION_TIMEOUT_MS); | ||
| } | ||
|
|
||
| public SessionPool(List<String> nodeUrls, String user, String password, int maxSize) { |
There was a problem hiding this comment.
Please update the sessionPool documentation to show greater fault tolerance when passing multiple endpoints like a session
Sorry, I can't add IT for this new feature. Because our IT environment only supports to run a single IoTDB Instance. In fact, this example code acts as a test. You can start IoTDB-server either on port 6667 or on port 6668 and this example code still work. |
SilverNarcissus
left a comment
SilverNarcissus
left a comment
There was a problem hiding this comment.
Look good to me~
5 participants
No description provided.