Skip to content

[IOTDB-2764] Refine the consensus layer framework and add examples#5277

Merged
qiaojialin merged 3 commits intomasterfrom
consensus
Mar 18, 2022
Merged

[IOTDB-2764] Refine the consensus layer framework and add examples#5277
qiaojialin merged 3 commits intomasterfrom
consensus

Conversation

@OneSizeFitsQuorum
Copy link
Contributor

@OneSizeFitsQuorum OneSizeFitsQuorum commented Mar 18, 2022

  • Improve the example of using consensus layer
  • Define ByteBufferConsensusRequest to allow the deserialization pushed down into the state machine, which is beneficial to avoid forwarding several rounds of multiple deserialization overhead.
  • Abstract BaseStateMachine to deserialize IConsenesusRequest so that its subclasses can focus only on standalone logic.

Copy link
Member

@wangchao316 wangchao316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OneSizeFitsQuorum OneSizeFitsQuorum marked this pull request as draft March 18, 2022 07:53
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 65.472% when pulling 57c2b22 on consensus into dc38c7a on master.

@OneSizeFitsQuorum OneSizeFitsQuorum marked this pull request as ready for review March 18, 2022 08:16
Copy link
Member

@neuyilan neuyilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qiaojialin qiaojialin merged commit b3fff9f into master Mar 18, 2022
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 15 Code Smells

10.3% 10.3% Coverage
8.8% 8.8% Duplication

@OneSizeFitsQuorum OneSizeFitsQuorum deleted the consensus branch March 18, 2022 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants