Skip to content

[IOTDB-2774] classloader isolation for MQTT plugin#5305

Merged
SteveYurongSu merged 1 commit intoapache:masterfrom
jamber001:IOTDB-2774
Mar 25, 2022
Merged

[IOTDB-2774] classloader isolation for MQTT plugin#5305
SteveYurongSu merged 1 commit intoapache:masterfrom
jamber001:IOTDB-2774

Conversation

@jamber001
Copy link
Contributor

Description

Content1 ...

Content2 ...

Content3 ...


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

@jamber001 jamber001 force-pushed the IOTDB-2774 branch 2 times, most recently from 3ad9ee0 to 380ebea Compare March 21, 2022 14:20
@SteveYurongSu SteveYurongSu self-requested a review March 22, 2022 01:33
@jamber001 jamber001 force-pushed the IOTDB-2774 branch 2 times, most recently from 838844c to ffd5e5f Compare March 22, 2022 02:52
@jamber001 jamber001 marked this pull request as draft March 22, 2022 02:57
@jamber001 jamber001 marked this pull request as ready for review March 25, 2022 01:49
@jamber001
Copy link
Contributor Author

@SteveYurongSu Could you help review this PR? :-)

Copy link
Member

@SteveYurongSu SteveYurongSu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this is a great improvement :D

@SteveYurongSu SteveYurongSu merged commit 44fb2d1 into apache:master Mar 25, 2022
@jamber001
Copy link
Contributor Author

Oh, this is a great improvement :D

Thank you! :-)

@jamber001 jamber001 deleted the IOTDB-2774 branch August 9, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants