[IOTDB-2727] async memory reservation#5317
Closed
cornmonster wants to merge 2 commits intoapache:masterfrom
Closed
[IOTDB-2727] async memory reservation#5317cornmonster wants to merge 2 commits intoapache:masterfrom
cornmonster wants to merge 2 commits intoapache:masterfrom
Conversation
JackieTien97
requested changes
Mar 22, 2022
|
|
||
| import org.apache.thrift.TException; | ||
|
|
||
| public class DataBlockServiceImpl implements DataBlockService.Iface { |
Contributor
There was a problem hiding this comment.
Why we delete this class?
|
|
||
| reservedBytes -= bytes; | ||
|
|
||
| List<MemoryReservationFuture<Void>> futures = |
Contributor
There was a problem hiding this comment.
In this way, if one query free its memory, it will only notify blocking Futures belonging to this query. Other queries won't be notified and still waiting.
And it seems that one free operation will only notify one blocking Future, but what if this freeing operation frees a large memory block which is large enough for multiple blocking Futures.
Contributor
Author
There was a problem hiding this comment.
Make sense. Will fix it.
|
|
||
| private long reservedBytes = 0L; | ||
| private final Map<String, Long> queryMemoryReservations = new HashMap<>(); | ||
| private final Map<String, List<MemoryReservationFuture<Void>>> queryIdToFutures = new HashMap<>(); |
Contributor
There was a problem hiding this comment.
We have QueryId class now, you can use that class to replace String.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Async memory reservation for input/output buffer management.