[IOTDB-2963]metrics of process and hardware#5406
[IOTDB-2963]metrics of process and hardware#5406SteveYurongSu merged 16 commits intoapache:masterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
wangchao316
left a comment
wangchao316
left a comment
There was a problem hiding this comment.
hi, thanks for your contribution.
you could raise a jira, and bind this pr.
SpriCoder
left a comment
SpriCoder
left a comment
There was a problem hiding this comment.
Excellent Job! There are only some minor problems need to fix.
Besides, I think some of these metrics should be CORE level, please have a check!
Finally, I think you need to give a performance test after introducing these metrics, so have a try of iotdb-benchmark.
| if (!firstInit.getAndSet(false)) { | ||
| startAllReporter(); | ||
| } | ||
|
|
||
| // if (!firstInit.getAndSet(false)) { | ||
| startAllReporter(); | ||
| // } |
There was a problem hiding this comment.
Please do not remove the usage if firstInit parameters, if you user startService of MetricService at first time, you can call startAllReporter() external.
| /** | ||
| * @author Erickin | ||
| * @create 2022-03-31-上午 8:55 | ||
| */ |
There was a problem hiding this comment.
Please do not add author and createTime message of class into master branch.
| /** | ||
| * @author Erickin | ||
| * @create 2022-03-31-下午 3:09 | ||
| */ |
There was a problem hiding this comment.
Please do not add author and createTime message of class into master branch.
| /** | ||
| * @author Erickin | ||
| * @create 2022-03-30-下午 3:45 | ||
| */ |
There was a problem hiding this comment.
Please do not add author and createTime message of class into master branch.
| @@ -0,0 +1,53 @@ | |||
| package org.apache.iotdb.db.metrics; | |||
There was a problem hiding this comment.
I think this file is no need to add into master for test.
| | process_cpu_load | name="process" | important | process当前CPU占用率（%） | process_cpu_load{name="process",} 5.0 | | ||
| | process_cpu_time | name="process" | important | process累计占用CPU时间（ns) | process_cpu_time{name="process",} 3.265625E9 | | ||
| | sys_cpu_load | name="system" | important | system当前CPU占用率（%） | sys_cpu_load{name="system",} 15.0 | | ||
| | sys_cpu_cores | name="system" | important | jvm可用处理器数 | sys_cpu_cores{name="system",} 16.0 | |
There was a problem hiding this comment.
I think these metrics should be CORE level.
| | process_max_mem | name="process" | important | process最大可用内存 | process_max_mem{name="process",} 3.545759744E9 | | ||
| | process_total_mem | name="process" | important | process当前占用内存 | process_total_mem{name="process",} 2.39599616E8 | | ||
| | process_free_mem | name="process" | important | process当前剩余可用内存 | process_free_mem{name="process",} 1.94035584E8 | |
There was a problem hiding this comment.
I think these metrics should be CORE level.
feat:Several new system and process monitoring metrics have been added.
ljn55966005
changed the title
feat:Several new system and process monitoring metrics have been added.
SteveYurongSu
left a comment
SteveYurongSu
left a comment
There was a problem hiding this comment.
Thanks for your wonderful job :D
BTW, Please merge the upstream master into your branch, the CI fails because of the legacy code on upstream master.
| | ---------- | -------------------- | ------ | ----------------------------------- | --------------------------- | | ||
| | file_size | name="wal/seq/unseq" | important | 当前时间wal/seq/unseq文件大小(byte) | file_size{name="wal",} 67.0 | | ||
| | file_count | name="wal/seq/unseq" | important | 当前时间wal/seq/unseq文件个数 | file_count{name="seq",} 1.0 | | ||
| | table_space | name="tablespace" | core | 表空间大小 | table_space{name="tablespace",} 0.0 | |
There was a problem hiding this comment.
What is the meaning of 表空间大小?
There was a problem hiding this comment.
Please update our English user docs accordingly.
fix:Delete the metric: table_space.
Co-authored-by: Erickin <956968575@qq.com> Co-authored-by: zhengqiang-cisdi <loveher147@qq.com> (cherry picked from commit 719a77a)
…actor from master (#6190) * [IOTDB-2963] metrics of process and hardware (#5406) Co-authored-by: Erickin <956968575@qq.com> Co-authored-by: zhengqiang-cisdi <loveher147@qq.com> (cherry picked from commit 719a77a) * remove enable_performance_stat in iotdb-engine.properties, and add enablePerformanceStat in iotdb-metric.yml (#5920) (cherry picked from commit e108016) * [IOTDB-3214] Refact predefined metrics in metric framework. (#5930) (cherry picked from commit dd1a28c) * [IOTDB-3214] Refact predefined metrics in metric framework. (#5930) (cherry picked from commit dd1a28c) * remove empty file. * fix compile. Co-authored-by: ljn55966005 <32378956+ljn55966005@users.noreply.github.com>
6 participants
feat:Several new system and process monitoring metrics have been added