Skip to content

[IoTDB-2837] Add check and sort for NumpyTablet to make sure timestamps are ordered#5434

Merged
HTHou merged 4 commits intoapache:masterfrom
ZhanGHanG9991:numpytabletzh
Apr 7, 2022
Merged

[IoTDB-2837] Add check and sort for NumpyTablet to make sure timestamps are ordered#5434
HTHou merged 4 commits intoapache:masterfrom
ZhanGHanG9991:numpytabletzh

Conversation

@ZhanGHanG9991
Copy link
Copy Markdown
Contributor

@ZhanGHanG9991 ZhanGHanG9991 commented Apr 6, 2022

Description

Add check and sort for NumpyTablet to make sure timestamps are ordered and format code with black .


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

@ZhanGHanG9991 ZhanGHanG9991 marked this pull request as ready for review April 6, 2022 15:25
Comment on lines 187 to 193
np_values_ = [
np.array([False, True, False, True], np.dtype('>?')),
np.array([10, 100, 100, 0], np.dtype('>i4')),
np.array([11, 11111, 1, 0], np.dtype('>i8')),
np.array([1.1, 1.25, 188.1, 0], np.dtype('>f4')),
np.array([10011.1, 101.0, 688.25, 6.25], np.dtype('>f8')),
np.array([False, True, False, True], np.dtype(">?")),
np.array([10, 100, 100, 0], np.dtype(">i4")),
np.array([11, 11111, 1, 0], np.dtype(">i8")),
np.array([1.1, 1.25, 188.1, 0], np.dtype(">f4")),
np.array([10011.1, 101.0, 688.25, 6.25], np.dtype(">f8")),
np.array(["test01", "test02", "test03", "test04"]),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, would you like to format the example code in user guide documents?
client-py/README.md, docs/UserGuide/API/Programming-Python-Native-API.mdand docs/zh/UserGuide/API/Programming-Python-Native-API.md.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've formatted the example code in docs.

@HTHou HTHou merged commit b1c391f into apache:master Apr 7, 2022
@ZhanGHanG9991 ZhanGHanG9991 deleted the numpytabletzh branch April 7, 2022 06:26
HTHou pushed a commit that referenced this pull request Apr 7, 2022
xinzhongtianxia pushed a commit to xinzhongtianxia/iotdb that referenced this pull request Apr 11, 2022
…er_meta

* remotes/upstream/master:
  [IOTDB-2859] Fix python tablet with None value is incorrect (apache#5441)
  Modify site/src/main/.vuepress/config.js to add  REST API navigation for v0.13 (apache#5442)
  [IoTDB-2837] Add check and sort for NumpyTablet to make sure timestamps are ordered (apache#5434)
  Implement mpp scheduler interface (apache#5438)
  [IOTDB-2855] Fix DeletionFileNodeTest error (apache#5435)
  [IOTDB-2853] there is low version of integration and jdbc in library-udf\pom.xml (apache#5436)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants