Skip to content

[IOTDB-3289][IOTDB-3291] Limit the number of regions#6087

Merged
qiaojialin merged 6 commits intoapache:masterfrom
CRZbulabula:validate_max_region_count
Jun 1, 2022
Merged

[IOTDB-3289][IOTDB-3291] Limit the number of regions#6087
qiaojialin merged 6 commits intoapache:masterfrom
CRZbulabula:validate_max_region_count

Conversation

@CRZbulabula
Copy link
Copy Markdown
Contributor

@CRZbulabula CRZbulabula commented May 31, 2022

For the safety of test environment, I make the following temporary changes:

  1. Only create SchemaRegion when create TimeSeries for the first time. And the number of SchemaRegions equals to the number of online DataNodes divides by schemaReplicationFactor.
  2. Only create DataRegion when data is written for the first time. And the number of DataRegions equals to the total cpu core number of online DataNodes times 0.3 then divides by dataReplicationFactor.
  3. Add an error log when heartbeat request failed.

@CRZbulabula CRZbulabula changed the title [IOTDB-3289][IOTDB-3291] Validate maxRegionCount [IOTDB-3289][IOTDB-3291] Limit the number of regions Jun 1, 2022
LOGGER.error(
String.format(
"Heartbeat error on DataNode: {id=%d, internalEndPoint=%s}, exception: %s",
dataNodeLocation.getDataNodeId(), dataNodeLocation.getInternalEndPoint(), e));
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOGGER.error("Heartbeat error on DataNode: id={}, internalEndPoint={}", dataNodeLocation.getDataNodeId(), dataNodeLocation.getInternalEndPoint(), e);

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed~

@CRZbulabula CRZbulabula changed the title [IOTDB-3289][IOTDB-3291] Limit the number of regions [IOTDB-3289][IOTDB-3291][IOTDB-3217] Limit the number of regions Jun 1, 2022
}

// Mark the StorageGroup as SchemaRegions and DataRegions not yet created
storageGroupSchema.setMaximumSchemaRegionCount(-1);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use 0?

@qiaojialin qiaojialin merged commit 92efe44 into apache:master Jun 1, 2022
@CRZbulabula CRZbulabula changed the title [IOTDB-3289][IOTDB-3291][IOTDB-3217] Limit the number of regions [IOTDB-3289][IOTDB-3291] Limit the number of regions Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants