[To rel/0.13][IOTDB-3969]Fix timeseries statistic bug#6808
Merged
HTHou merged 4 commits intoapache:rel/0.13from Jul 28, 2022
Merged
[To rel/0.13][IOTDB-3969]Fix timeseries statistic bug#6808HTHou merged 4 commits intoapache:rel/0.13from
HTHou merged 4 commits intoapache:rel/0.13from
Conversation
MarcosZyk
changed the title
SpriCoder
requested changes
Jul 28, 2022
Comment on lines
+321
to
+337
| .getOrCreateAutoGauge( | ||
| Metric.QUANTITY.toString(), | ||
| MetricLevel.IMPORTANT, | ||
| totalSeriesNumber, | ||
| totalNormalSeriesNumber, | ||
| AtomicLong::get, | ||
| Tag.NAME.toString(), | ||
| "timeSeries"); | ||
| "normal-timeSeries"); | ||
|
|
||
| MetricsService.getInstance() | ||
| .getMetricManager() | ||
| .getOrCreateAutoGauge( | ||
| Metric.QUANTITY.toString(), | ||
| MetricLevel.IMPORTANT, | ||
| totalTemplateSeriesNumber, | ||
| AtomicLong::get, | ||
| Tag.NAME.toString(), | ||
| "template-timeSeries"); |
Contributor
There was a problem hiding this comment.
From my perspective, I think these two metrics can use type tag to distinguish.
For example, TAG.NAME.toString(), "timeSeries", TAG.TYPE.toString(), "normal/template"
Besides, please update Metric doc at the same time:
- docs/UserGuide/Maintenance-Tools/Metric-Tool.md
- docs/zh/UserGuide/Maintenance-Tools/Metric-Tool.md
This was referenced Apr 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
When delete storage group, the timeseries represent by template will be counted and the result will be used to update the timeseries statistic number. The number doesn't update when activate template. Thus the number will be negative.
Solution
Use two number to statistic template series and normal series separately.