[IOTDB-3164] Manage the memory of cross space compaction in write memory controller #6914

THUMarkLau · 2022-08-08T09:07:37Z

See IOTDB-3164.

This PR is one part of the compaction memory management. It does the following jobs:

Allocate memory before cross space compaction, and release the memory after the execution.
Remove the RewriteCompactionFileSelector, which is deduplicated with RewriteCrossSpaceCompactionSelector.

To complete the compaction memory management, we need to complete the following jobs:

Manage the memory usage of unsequence inner space compaction, which uses read point performer.
Design and implement the memory estimator for read chunk performer.
Manage the memory usage of sequence inner space comapction, which uses read chunk performer.

coveralls · 2022-08-08T12:03:27Z

Coverage increased (+0.02%) to 42.338% when pulling ad73693 on IOTDB-3164-O into 37d6cfe on master.

THUMarkLau · 2022-08-10T05:55:38Z

I use IoTDB benchmark tests changed after the performance, and the master (commit: a8f757d) are compared. The result of the comparison is shown in the figure below. In terms of average performance, the write performance after the change decreases by about 2.8%.

master branch

with memory management for cross space compaction

qiaojialin · 2022-08-25T12:33:21Z

...org/apache/iotdb/db/engine/compaction/cross/rewrite/RewriteCrossSpaceCompactionSelector.java

    this.dataRegionId = dataRegionId;
    this.timePartition = timePartition;
    this.tsFileManager = tsFileManager;
+    this.memoryBudget = config.getCrossCompactionMemoryBudget();


apply this memory from the storage engine, not from the whole system

qiaojialin · 2022-08-26T07:44:10Z

server/src/main/java/org/apache/iotdb/db/conf/IoTDBConfig.java


  /** How much memory (in byte) can be used by a single merge task. */
-  private long crossCompactionMemoryBudget = (long) (Runtime.getRuntime().maxMemory() * 0.1);
+  private long crossCompactionMemoryBudget = (long) (allocateMemoryForWrite * 0.1D);


The default variable is

private double compactionProportion = 0.2;

Suggested change

private long crossCompactionMemoryBudget = (long) (allocateMemoryForWrite * 0.1D);

private long crossCompactionMemoryBudget = (long) (allocateMemoryForWrite * 0.2D);

qiaojialin · 2022-08-26T07:50:45Z

server/src/main/java/org/apache/iotdb/db/rescon/SystemInfo.java


-  private static long memorySizeForWrite = config.getAllocateMemoryForWrite();
+  private static long memorySizeForWrite =
+      (long) (config.getAllocateMemoryForWrite() * config.getMemtableProportion());


Suggested change

(long) (config.getAllocateMemoryForWrite() * config.getMemtableProportion());

(long) (config.getAllocateMemoryForStorageEngine() * config.getWriteProportion());

qiaojialin · 2022-08-26T10:50:25Z

server/src/main/java/org/apache/iotdb/db/conf/IoTDBConfig.java


  /** How much memory (in byte) can be used by a single merge task. */
-  private long crossCompactionMemoryBudget = (long) (Runtime.getRuntime().maxMemory() * 0.1);
+  private long crossCompactionMemoryBudget = (long) (allocateMemoryForWrite * 0.1D);


Suggested change

private long crossCompactionMemoryBudget = (long) (allocateMemoryForWrite * 0.1D);

private long compactionMemoryBudget = (long) (allocateMemoryForStorageEngine * compactionProportion);

This param is removed

qiaojialin · 2022-08-26T15:15:00Z

https://apache-iotdb.feishu.cn/docx/doxcnuh5hy6ee9Qb7uLCYXkFDdc

qiaojialin · 2022-08-27T07:46:06Z

server/src/main/java/org/apache/iotdb/db/engine/compaction/cross/CrossSpaceCompactionTask.java

  @Override
  protected void doCompaction() {
    try {
+      SystemInfo.getInstance().addCompactionMemoryCost(memoryCost);


what if the allocateMemory throw interrupt exception without succeeding in adding?

I move allocateMemory in a seperate try-catch block.

…tion main execution

sonarqubecloud · 2022-08-27T12:06:34Z

SonarCloud Quality Gate failed.

2 Bugs
0 Vulnerabilities
0 Security Hotspots
11 Code Smells

89.5% Coverage
0.0% Duplication

qiaojialin · 2022-08-28T13:41:33Z

server/src/main/java/org/apache/iotdb/db/rescon/SystemInfo.java


+  public void addCompactionMemoryCost(long memoryCost) throws InterruptedException {
+    long originSize = this.compactionMemoryCost.get();
+    while (originSize + memoryCost > memorySizeForCompaction


If there are two tasks call this method concurrently,
Task1 originSize = 10;
Task2 originSize = 10;
Task1.compactionMemoryCost.compacreAndSet(10, 10+30) = 40;
Task2 compareAndSet is always false, and Task2 sleeps forever.

The originSize is updated in the while block.

HTHou

LGTM

THUMarkLau added 2 commits August 8, 2022 11:58

remove RewriteCompactionFileSelector

136418c

add cross compaction memory budget to system info

044ef7c

THUMarkLau requested review from HTHou and qiaojialin August 8, 2022 09:08

fix compilation problem

b822582

qiaojialin requested changes Aug 25, 2022

View reviewed changes

THUMarkLau added 3 commits August 26, 2022 15:02

allocate memory for compaction from write proportion

44e7623

merge with upstream/master

f814864

merge with master

16d6b00

qiaojialin reviewed Aug 26, 2022

View reviewed changes

add configuration for storage engine memory proportion

9c4a3cc

qiaojialin reviewed Aug 26, 2022

View reviewed changes

remove config item cross_space_compaction_memory_budget

fa472d1

qiaojialin reviewed Aug 27, 2022

View reviewed changes

allocate memory for compaction outside the try-catch block for compac…

ad73693

…tion main execution

qiaojialin requested changes Aug 28, 2022

View reviewed changes

qiaojialin approved these changes Aug 29, 2022

View reviewed changes

HTHou approved these changes Aug 29, 2022

View reviewed changes

qiaojialin merged commit f218f0b into master Aug 29, 2022

qiaojialin deleted the IOTDB-3164-O branch August 29, 2022 04:26

THUMarkLau mentioned this pull request Aug 29, 2022

[To rel/0.13][IOTDB-3164] Add compaction memory control framework #7162

Merged

	private long crossCompactionMemoryBudget = (long) (allocateMemoryForWrite * 0.1D);
	private long crossCompactionMemoryBudget = (long) (allocateMemoryForWrite * 0.2D);

	(long) (config.getAllocateMemoryForWrite() * config.getMemtableProportion());
	(long) (config.getAllocateMemoryForStorageEngine() * config.getWriteProportion());

	private long crossCompactionMemoryBudget = (long) (allocateMemoryForWrite * 0.1D);
	private long compactionMemoryBudget = (long) (allocateMemoryForStorageEngine * compactionProportion);

[IOTDB-3164] Manage the memory of cross space compaction in write memory controller #6914

[IOTDB-3164] Manage the memory of cross space compaction in write memory controller #6914

Uh oh!

Conversation

THUMarkLau commented Aug 8, 2022

Uh oh!

coveralls commented Aug 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

THUMarkLau commented Aug 10, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

qiaojialin commented Aug 26, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Aug 27, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HTHou left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coveralls commented Aug 8, 2022 •

edited

Loading