[IOTDB-4125] Clear NodeCache and RegionGroupCache in time#7057
Merged
Beyyes merged 1 commit intoapache:masterfrom Aug 21, 2022
Merged
Conversation
wangchao316
reviewed
Aug 19, 2022
| LOG.info("Remove Consensus Group {}", tConfigNodeLocation); | ||
| break; | ||
| case STOP_CONFIG_NODE: | ||
| env.broadCastTheLatestConfigNodeGroup(); |
Member
There was a problem hiding this comment.
why ? We should broadcast and quarantine before we delete it.
Contributor
Author
There was a problem hiding this comment.
The old framework broadcasts as soon as the RemoveConfigNodeProcedure begins, which means the broadcasted ConfigNodeList still contain the ConfigNode to be removed. Therefore, we should broadcast the ConfigNodeList after we actually remove this ConfigNode.
Beyyes
approved these changes
Aug 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.