You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@HeimingZ Are there any other code blocks that should be changed as well? If one code uses synchronized keyword, then there must be at least another one.
@HeimingZ Are there any other code blocks that should be changed as well? If one code uses synchronized keyword, then there must be at least another one.
@ericpai Just block here is ok, this method is the only interface to get data region. For example, when two threads hold different MNode to get the same data region, they will block at the same ready condition.
@HeimingZ Are there any other code blocks that should be changed as well? If one code uses synchronized keyword, then there must be at least another one.
@ericpai Just block here is ok, this method is the only interface to get data region. For example, when two threads hold different MNode to get the same data region, they will block at the same ready condition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synchronize ready condition rather than MNode. Besides, StorageEngineV2 doesn‘t have this problem.