Skip to content

[IOTDB-4222] Create data region repeatedly when concurrently deleting and creating storage groups#7112

Merged
ericpai merged 1 commit intoapache:masterfrom
HeimingZ:IOTDB-4222
Aug 25, 2022
Merged

[IOTDB-4222] Create data region repeatedly when concurrently deleting and creating storage groups#7112
ericpai merged 1 commit intoapache:masterfrom
HeimingZ:IOTDB-4222

Conversation

@HeimingZ
Copy link
Contributor

@HeimingZ HeimingZ commented Aug 24, 2022

Synchronize ready condition rather than MNode. Besides, StorageEngineV2 doesn‘t have this problem.

@HTHou HTHou requested a review from ericpai August 25, 2022 01:37
@ericpai
Copy link
Member

ericpai commented Aug 25, 2022

@HeimingZ Are there any other code blocks that should be changed as well? If one code uses synchronized keyword, then there must be at least another one.

@HeimingZ
Copy link
Contributor Author

@HeimingZ Are there any other code blocks that should be changed as well? If one code uses synchronized keyword, then there must be at least another one.

@ericpai Just block here is ok, this method is the only interface to get data region. For example, when two threads hold different MNode to get the same data region, they will block at the same ready condition.

@ericpai
Copy link
Member

ericpai commented Aug 25, 2022

@HeimingZ Are there any other code blocks that should be changed as well? If one code uses synchronized keyword, then there must be at least another one.

@ericpai Just block here is ok, this method is the only interface to get data region. For example, when two threads hold different MNode to get the same data region, they will block at the same ready condition.

Thanks. LGTM!

@ericpai ericpai merged commit 94657cf into apache:master Aug 25, 2022
@HeimingZ HeimingZ deleted the IOTDB-4222 branch August 25, 2022 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants