Guarantee Atomicity in Ratis InstallSnapshot RPC#7131
Merged
JackieTien97 merged 2 commits intoapache:masterfrom Aug 30, 2022
Merged
Guarantee Atomicity in Ratis InstallSnapshot RPC#7131JackieTien97 merged 2 commits intoapache:masterfrom
JackieTien97 merged 2 commits intoapache:masterfrom
Conversation
JackieTien97
approved these changes
Aug 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently RatisConsensus uses a metafile to control snapshot atomicity. That is, a metafile is added to snapshot directory last, and we judge a snapshot directory's completeness by the existence of this metafile.
Therefore, we have to guarantee this order when sending snapshot directory via network. That is, the metafile must be transmitted last.