[IOTDB-4114] Add safety check for createPeer#7133
Closed
SzyWilliam wants to merge 1 commit intoapache:masterfrom
Closed
[IOTDB-4114] Add safety check for createPeer#7133SzyWilliam wants to merge 1 commit intoapache:masterfrom
SzyWilliam wants to merge 1 commit intoapache:masterfrom
Conversation
JackieTien97
requested changes
Aug 30, 2022
Comment on lines
+260
to
+265
| RaftGroupId raftGroupId = Utils.fromConsensusGroupIdToRaftGroupId(groupId); | ||
| RaftGroup existGroup = getGroupInfo(raftGroupId); | ||
| // pre-conditions: the new group not exists | ||
| if (existGroup != null) { | ||
| return failed(new ConsensusGroupAlreadyExistException(groupId)); | ||
| } |
Contributor
There was a problem hiding this comment.
It seems that even if you do this check, it could not totally prevent this problem because this checking and creating are not atomically.
Member
Author
|
This Pr should be close because the issue4114 is caused by starting confignode twice on one single machine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When ConfigNode or DataNode calls
Consensus.createPeertwice with exact groupID,RatisConsensuswill allow the secondcreatePeerto be executed. This will cause unexpected errors, as overlapping files could interfere each other.In this PR I propose to add a pre-condition check in
createPeerso that the same Peer will not be created twice on one node.