[IOTDB-4361] Add a precheck in removing datanode#7264
Merged
Beyyes merged 13 commits intoapache:masterfrom Sep 14, 2022
MiniSho:remove-datanode-precheck
Merged
[IOTDB-4361] Add a precheck in removing datanode#7264Beyyes merged 13 commits intoapache:masterfrom MiniSho:remove-datanode-precheck
Beyyes merged 13 commits intoapache:masterfrom
MiniSho:remove-datanode-precheck
Conversation
1. check replication factor 2. make sure datanode is in running
SpriCoder
approved these changes
Sep 8, 2022
Beyyes
reviewed
Sep 9, 2022
CRZbulabula
requested changes
Sep 10, 2022
Contributor
Author
|
the configuration is Standalone protocol and when it removes a data node, it will throw an error |
Contributor
Author
|
when remove a datanode whic is not in running state and the configuration of cluster is one replication, it throws an error |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should add a precheck when the confignode executes removing datanode :
screenshot：
the configuration is Standalone protocol and when it removes a data node, it will throw an error：
when remove a datanode whic is not in running state and the configuration of cluster is one replication, it throws an error：
In addition, new a package called confignode in ConfigNodeIT.