Skip to content

[IOTDB-4366] Fix Ratis 1 replica migrate error; terminate the RegionMigrationProcedure process when datanode report failure result#7269

Merged
qiaojialin merged 20 commits intomasterfrom
beyyes/fix_procedure_bug
Sep 15, 2022
Merged

[IOTDB-4366] Fix Ratis 1 replica migrate error; terminate the RegionMigrationProcedure process when datanode report failure result#7269
qiaojialin merged 20 commits intomasterfrom
beyyes/fix_procedure_bug

Conversation

@Beyyes
Copy link
Copy Markdown
Member

@Beyyes Beyyes commented Sep 8, 2022

Description

Two improvements:

  1. executing remove-datanode.sh for Ratis 1 replica will be failed in the deleteOldRegion step, so we cancel the step of deleteOldRegion in RegionMigrateProcedure in the case of Ratis 1 replica.
    image

  2. RegionMigrateProcedure step will be terminated when the datanode reported failed.
    image

The test running results are as below.

SchemaRegion=Ratis, DataRegion=Ratis

Before remove datanode:
image

After remove the datanode 0.0.0.0:6669
image

jps result:
image
image

@Beyyes Beyyes changed the title Fix Ratis 1 replica migrate error; terminate the procedure process when datanode report failure result [IOTDB-4366] Fix Ratis 1 replica migrate error; terminate the procedure process when datanode report failure result Sep 8, 2022
@coveralls
Copy link
Copy Markdown

coveralls commented Sep 14, 2022

Coverage Status

Coverage increased (+0.004%) to 40.882% when pulling 91b41d3 on beyyes/fix_procedure_bug into c85d80e on master.

@sonarqubecloud
Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

6.3% 6.3% Coverage
0.0% 0.0% Duplication

Copy link
Copy Markdown
Contributor

@CRZbulabula CRZbulabula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@qiaojialin qiaojialin changed the title [IOTDB-4366] Fix Ratis 1 replica migrate error; terminate the procedure process when datanode report failure result [IOTDB-4366] Fix Ratis 1 replica migrate error; terminate the RegionMigrationProcedure process when datanode report failure result Sep 15, 2022
@qiaojialin qiaojialin merged commit 4bebeee into master Sep 15, 2022
@qiaojialin qiaojialin deleted the beyyes/fix_procedure_bug branch September 15, 2022 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants