[IOTDB-4251] Persist ChunkMetadata in TsFileIOWriter ahead of time to save memory #7276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd corresponding test
|
Coverage decreased (-0.1%) to 40.939% when pulling 97c34e9 on IOTDB-4251 into b71569a on master. |
|
Kudos, SonarCloud Quality Gate passed! |
JackieTien97
requested changes
Sep 13, 2022
Contributor
JackieTien97
left a comment
JackieTien97
left a comment
There was a problem hiding this comment.
We should discuss more about the temp file format, no need to serialize FullPath for each chunkmetadata.
And BTW, I think we should share the same endFile() function. The only difference is how we get ChunkMetadataList, whether from disk or memory or both disk & memory.
...r/src/main/java/org/apache/iotdb/db/engine/compaction/writer/CrossSpaceCompactionWriter.java
Outdated
Show resolved
Hide resolved
...r/src/main/java/org/apache/iotdb/db/engine/compaction/writer/InnerSpaceCompactionWriter.java
Outdated
Show resolved
Hide resolved
tsfile/src/main/java/org/apache/iotdb/tsfile/file/metadata/AlignedChunkMetadata.java
Outdated
Show resolved
Hide resolved
tsfile/src/main/java/org/apache/iotdb/tsfile/file/metadata/ChunkMetadata.java
Outdated
Show resolved
Hide resolved
tsfile/src/main/java/org/apache/iotdb/tsfile/file/metadata/ChunkMetadata.java
Outdated
Show resolved
Hide resolved
tsfile/src/main/java/org/apache/iotdb/tsfile/write/writer/MemoryControlTsFileIOWriter.java
Outdated
Show resolved
Hide resolved
tsfile/src/main/java/org/apache/iotdb/tsfile/write/writer/TsFileIOWriter.java
Outdated
Show resolved
Hide resolved
tsfile/src/main/java/org/apache/iotdb/tsfile/write/writer/MemoryControlTsFileIOWriter.java
Outdated
Show resolved
Hide resolved
tsfile/src/main/java/org/apache/iotdb/tsfile/write/writer/MemoryControlTsFileIOWriter.java
Outdated
Show resolved
Hide resolved
tsfile/src/main/java/org/apache/iotdb/tsfile/write/writer/MemoryControlTsFileIOWriter.java
Outdated
Show resolved
Hide resolved
JackieTien97
requested changes
Sep 20, 2022
example/tsfile/src/main/java/org/apache/iotdb/tsfile/TsFileSequenceRead.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/iotdb/db/engine/storagegroup/TsFileResource.java
Show resolved
Hide resolved
Comment on lines
495
to
496
| Map<String, List<TimeseriesMetadata>> deviceTimeseriesMetadataMap = | ||
| tsFileIOWriter.getDeviceTimeseriesMetadataMap(); |
Contributor
There was a problem hiding this comment.
There is no need to read all TimeSeriesMetadata at once here.
Contributor
Author
There was a problem hiding this comment.
This method is used when loading tsfile, all the chunk metadata is in the memory, there is no IO overhead to return all the data at once.
Comment on lines
+549
to
+572
| Map<String, List<TimeseriesMetadata>> deviceTimeseriesMetadataMap = new TreeMap<>(); | ||
| Map<String, Map<String, List<IChunkMetadata>>> chunkMetadataMap = new TreeMap<>(); | ||
| for (ChunkGroupMetadata chunkGroupMetadata : chunkGroupMetadataList) { | ||
| for (ChunkMetadata chunkMetadata : chunkGroupMetadata.getChunkMetadataList()) { | ||
| chunkMetadataMap | ||
| .computeIfAbsent(chunkGroupMetadata.getDevice(), x -> new TreeMap<>()) | ||
| .computeIfAbsent(chunkMetadata.getMeasurementUid(), x -> new ArrayList<>()) | ||
| .add(chunkMetadata); | ||
| } | ||
| } | ||
| for (String device : chunkMetadataMap.keySet()) { | ||
| Map<String, List<IChunkMetadata>> seriesToChunkMetadataMap = chunkMetadataMap.get(device); | ||
| for (Map.Entry<String, List<IChunkMetadata>> entry : seriesToChunkMetadataMap.entrySet()) { | ||
| try { | ||
| deviceTimeseriesMetadataMap | ||
| .computeIfAbsent(device, x -> new ArrayList<>()) | ||
| .add(TSMIterator.constructOneTimeseriesMetadata(entry.getKey(), entry.getValue())); | ||
| } catch (IOException e) { | ||
| logger.error("Failed to get device timeseries metadata map", e); | ||
| return null; | ||
| } | ||
| } | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
It seems that this method only contains chunkmetadata in memory.
tsfile/src/main/java/org/apache/iotdb/tsfile/write/writer/tsmiterator/TSMIterator.java
Outdated
Show resolved
Hide resolved
tsfile/src/main/java/org/apache/iotdb/tsfile/write/writer/tsmiterator/DiskTSMIterator.java
Outdated
Show resolved
Hide resolved
tsfile/src/main/java/org/apache/iotdb/tsfile/write/writer/tsmiterator/DiskTSMIterator.java
Show resolved
Hide resolved
tsfile/src/main/java/org/apache/iotdb/tsfile/write/writer/tsmiterator/TSMIterator.java
Outdated
Show resolved
Hide resolved
tsfile/src/main/java/org/apache/iotdb/tsfile/write/writer/TsFileIOWriter.java
Outdated
Show resolved
Hide resolved
tsfile/src/main/java/org/apache/iotdb/tsfile/write/writer/TsFileIOWriter.java
Outdated
Show resolved
Hide resolved
THUMarkLau
force-pushed
the
IOTDB-4251
branch
from
ab09860 to
5cccdab
Compare
JackieTien97
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See IOTDB-4251.