Skip to content

[IOTDB-4493] Fix null message in TSStatus. #7402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HTHou merged 1 commit into from
Sep 22, 2022
Merged

[IOTDB-4493] Fix null message in TSStatus. #7402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions confignode/src/main/java/org/apache/iotdb/confignode/manager/partition/PartitionManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,11 +352,15 @@ private TSStatus extendRegionsIfNecessary(
result = RpcUtils.SUCCESS_STATUS;
}
} catch (NotEnoughDataNodeException e) {
LOGGER.error("ConfigNode failed to extend Region because there are not enough DataNodes");
String prompt = "ConfigNode failed to extend Region because there are not enough DataNodes";
LOGGER.error(prompt);
result.setCode(TSStatusCode.NOT_ENOUGH_DATA_NODE.getStatusCode());
result.setMessage(prompt);
} catch (StorageGroupNotExistsException e) {
LOGGER.error("ConfigNode failed to extend Region because some StorageGroup doesn't exist.");
String prompt = "ConfigNode failed to extend Region because some StorageGroup doesn't exist.";
LOGGER.error(prompt);
result.setCode(TSStatusCode.STORAGE_GROUP_NOT_EXIST.getStatusCode());
result.setMessage(prompt);
}

return result;
Expand Down
4 changes: 3 additions & 1 deletion consensus/src/main/java/org/apache/iotdb/consensus/multileader/MultiLeaderServerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,9 @@ public TSStatus write(IConsensusRequest request) {
!stateMachineCondition.await(
config.getReplication().getThrottleTimeOutMs(), TimeUnit.MILLISECONDS);
if (timeout) {
return RpcUtils.getStatus(TSStatusCode.WRITE_PROCESS_REJECT);
return RpcUtils.getStatus(
TSStatusCode.WRITE_PROCESS_REJECT,
"Reject write because there are too many requests need to process");
}
} catch (InterruptedException e) {
logger.error("Failed to throttle down because ", e);
Expand Down