Skip to content

Fix thrift access level #7478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JackieTien97 merged 1 commit into from
Sep 29, 2022
Merged

Fix thrift access level #7478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions consensus/src/main/java/org/apache/iotdb/consensus/ratis/SnapshotStorage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,11 +155,9 @@ void updateSnapshotCache() {

@Override
public SnapshotInfo getLatestSnapshot() {
SnapshotInfo latestSnapshot;
snapshotCacheGuard.readLock().lock();
try {
latestSnapshot = currentSnapshot;
return latestSnapshot;
return currentSnapshot;
} finally {
snapshotCacheGuard.readLock().unlock();
}
Expand Down
28 changes: 14 additions & 14 deletions thrift-confignode/src/main/thrift/confignode.thrift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,26 +49,26 @@ struct TGlobalConfig {
}

struct TRatisConfig {
1: optional i64 schemaAppenderBufferSize
2: optional i64 dataAppenderBufferSize
1: required i64 schemaAppenderBufferSize
2: required i64 dataAppenderBufferSize

3: optional i64 schemaSnapshotTriggerThreshold
4: optional i64 dataSnapshotTriggerThreshold
3: required i64 schemaSnapshotTriggerThreshold
4: required i64 dataSnapshotTriggerThreshold

5: optional bool schemaLogUnsafeFlushEnable
6: optional bool dataLogUnsafeFlushEnable
5: required bool schemaLogUnsafeFlushEnable
6: required bool dataLogUnsafeFlushEnable

7: optional i64 schemaLogSegmentSizeMax
8: optional i64 dataLogSegmentSizeMax
7: required i64 schemaLogSegmentSizeMax
8: required i64 dataLogSegmentSizeMax

9: optional i64 schemaGrpcFlowControlWindow
10: optional i64 dataGrpcFlowControlWindow
9: required i64 schemaGrpcFlowControlWindow
10: required i64 dataGrpcFlowControlWindow

11: optional i64 schemaLeaderElectionTimeoutMin
12: optional i64 dataLeaderElectionTimeoutMin
11: required i64 schemaLeaderElectionTimeoutMin
12: required i64 dataLeaderElectionTimeoutMin

13: optional i64 schemaLeaderElectionTimeoutMax
14: optional i64 dataLeaderElectionTimeoutMax
13: required i64 schemaLeaderElectionTimeoutMax
14: required i64 dataLeaderElectionTimeoutMax
}

struct TDataNodeRemoveReq {
Expand Down