Skip to content

[IOTDB-4250][IOTDB-4628] Support multiple pipes and update drop semantics#7581

Merged
HTHou merged 8 commits intoapache:masterfrom
Cpaulyz:IOTDB-4250
Oct 19, 2022
Merged

[IOTDB-4250][IOTDB-4628] Support multiple pipes and update drop semantics#7581
HTHou merged 8 commits intoapache:masterfrom
Cpaulyz:IOTDB-4250

Conversation

@Cpaulyz
Copy link
Contributor

@Cpaulyz Cpaulyz commented Oct 12, 2022

Description

IOTDB-4250

Support multiple pipes running at the same time.
multipipe

IOTDB-4628

In old version, pipe infomation will be stored even if pipe has been dropped. There are two advantages to not storing pipe infomation after drop can.

  1. Support rollback logic in procedure better. If failed to create pipe, drop directlt.
  2. Other modules(e.g.Trigger) do the same thing. Doing so can keep the semantics consistent in IoTDB.

@Cpaulyz Cpaulyz marked this pull request as draft October 12, 2022 12:51
@Cpaulyz Cpaulyz marked this pull request as ready for review October 13, 2022 01:55
Copy link
Member

@neuyilan neuyilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines 141 to 142
String.format("Can not find PIPESINK [%s].", pipeInfo.getPipeSinkName()));
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use PipeSinkNotExistException?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@HTHou HTHou merged commit 75d8538 into apache:master Oct 19, 2022
@Cpaulyz Cpaulyz deleted the IOTDB-4250 branch October 19, 2022 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants