[IOTDB-4627]Trigger transfer #7643
Conversation
Signed-off-by: Weihao Li <18110526956@163.com>
Signed-off-by: Weihao Li <18110526956@163.com>
Signed-off-by: Weihao Li <18110526956@163.com>
…ss of RemovingNode Signed-off-by: Weihao Li <18110526956@163.com>
Signed-off-by: Weihao Li <18110526956@163.com>
| // do transfer of the DataNodes before remove | ||
| if (configManager.transfer(removeDataNodePlan.getDataNodeLocations()).getCode() | ||
| != TSStatusCode.SUCCESS_STATUS.getStatusCode()) { | ||
| dataSet.setStatus( | ||
| new TSStatus(TSStatusCode.NODE_DELETE_FAILED_ERROR.getStatusCode()) | ||
| .setMessage("Fail to do transfer of the DataNodes")); | ||
| return dataSet; | ||
| } |
There was a problem hiding this comment.
Is the transfer process should be such important that the DataNode remove process couldn't continue as long as if it fails down?
There was a problem hiding this comment.
Yes, I think we should ensure the safety of data.
There was a problem hiding this comment.
Remove data process used RemoveDataProcedure and sub RegionMigrateProcedures,
Will triggers implement it later or using other methods?
Or some errors may happen when ConfigNode down/restart.
There was a problem hiding this comment.
We used to consider implement by Procedure, but later we found that we did not need to roll back when the transfer failed.
Signed-off-by: Weihao Li <18110526956@163.com>
| * @return result of transferTrigger | ||
| */ | ||
| public TSStatus transferTrigger( | ||
| List<TDataNodeLocation> newUnknownDataList, |
There was a problem hiding this comment.
| List<TDataNodeLocation> newUnknownDataList, | |
| List<TDataNodeLocation> newUnknownDataNodeList, |
|
|
||
| public List<TSStatus> updateTriggerLocation( | ||
| String triggerName, | ||
| TDataNodeLocation dataNodeLocation, |
There was a problem hiding this comment.
parameter dataNodeLocation and dataNodeLocationMap are similar, maybe we can change dataNodeLocation to targetDataNode?
| // do transfer of the DataNodes before remove | ||
| if (configManager.transfer(removeDataNodePlan.getDataNodeLocations()).getCode() | ||
| != TSStatusCode.SUCCESS_STATUS.getStatusCode()) { | ||
| dataSet.setStatus( | ||
| new TSStatus(TSStatusCode.NODE_DELETE_FAILED_ERROR.getStatusCode()) | ||
| .setMessage("Fail to do transfer of the DataNodes")); | ||
| return dataSet; | ||
| } |
There was a problem hiding this comment.
Remove data process used RemoveDataProcedure and sub RegionMigrateProcedures,
Will triggers implement it later or using other methods?
Or some errors may happen when ConfigNode down/restart.
5 participants
1.Transfer stateful triggers when DataNode Status is Unknown;
2.Transfer stateful triggers when DataNode remove;
3.Has been tested, can see Trigger测试方案
4.Cooperate with @lancelly.