Skip to content

[IoTDB-400] Support rest api#777

Closed
Genius-pig wants to merge 118 commits intomasterfrom
http
Closed

[IoTDB-400] Support rest api#777
Genius-pig wants to merge 118 commits intomasterfrom
http

Conversation

@Genius-pig
Copy link
Contributor

Support rest api.

logger.error("The host is unknow", e);
}
return ia.getHostName();
return Objects.requireNonNull(ia).getHostName();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change ia to a more meaningful name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

* Unless required by applicable law or agreed to in writing, software distributed under the License
* is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
* or implied. See the License for the specific language governing permissions and limitations under
* the License.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed


package org.apache.iotdb.db.rest.model;

public class TimeValues {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public class TimeValues {
public class TimeValue {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

* @param request this request will be in json format.
* @return json in String
*/
@Path("/query")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a UserGuide of rest apis

@Genius-pig
Copy link
Contributor Author

@SteveYurongSu, please check out again. I don't compile web resources. Because it will cost more time and more memory in ci. Before this, please look at readme.md on the web package.

@Genius-pig
Copy link
Contributor Author

It was just a single web page, I don't think it needs ci for now.

@giorgiozoppi
Copy link

Is it possible having something more simple/efficient, like:
https://netty.io/4.1/xref/io/netty/example/http/snoop/HttpSnoopServer.html

@Genius-pig
Copy link
Contributor Author

@giorgiozoppi It's a good idea to use netty. I will try it.

@Genius-pig
Copy link
Contributor Author

Genius-pig commented May 18, 2020

Not just rest API, I also want the webserver to handle static resources. seems like if you used netty, you would have to write a static file handler. @giorgiozoppi

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 6 Security Hotspots to review)
Code Smell A 26 Code Smells

No Coverage information No Coverage information
2.0% 2.0% Duplication

@qiaojialin qiaojialin closed this Nov 13, 2020
@qiaojialin qiaojialin deleted the http branch November 13, 2020 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants