Fix Segment size estimation in SchemaFile#8003
Merged
MarcosZyk merged 1 commit intoapache:masterfrom Nov 21, 2022
Merged
Conversation
MarcosZyk
approved these changes
Nov 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pr fixs a bug involved from #7726 where tried to optimize performance by an extra segment estimation method. The method takes into account the size of write batch but ignores to compare it with the original size, which throws an exception with message that cannot extend a segment into a smaller buffer.
The problem is fixed by this pr, in comany with a new ut to verify it.