[To rel/1.0] [IOTDB-5059] Remove redundant database check in SchemaEngine#8236
Merged
MarcosZyk merged 2 commits intoapache:rel/1.0from Nov 29, 2022
Merged
[To rel/1.0] [IOTDB-5059] Remove redundant database check in SchemaEngine#8236MarcosZyk merged 2 commits intoapache:rel/1.0from
MarcosZyk merged 2 commits intoapache:rel/1.0from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since the database name has already been checked on configNode when creating database, there's no need to check it again in SchemaEngine. We suppose all the internal requests are legal and SchemaEngine only need to execute them.
The async physical deletion of schemaRegion affects the creation of new region of new database with nested name, e.g. old db is root.udf and new db is root.udf.load, which results in the creation failure of new region and this shall not happen.