[IOTDB-5286]Fix target files should not be select to participate in other compaction task#8615
Merged
THUMarkLau merged 5 commits intoapache:masterfrom Jan 1, 2023
Merged
Conversation
THUMarkLau
approved these changes
Dec 28, 2022
xingtanzjr
reviewed
Dec 29, 2022
|
|
||
| /** Used for compaction to create target files. */ | ||
| public TsFileResource(File file, TsFileResourceStatus status) { | ||
| this.file = file; |
Contributor
There was a problem hiding this comment.
using this(file) to reduce duplicated codes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the system is restarted, a compaction error is reported: the source file is deleted and the target file is also deleted, which will set allowCompaction to false.
Reason
Target files are selected to participate in other compaction tasks before the end of the current task, causing unexpected errors.
Solution
Set target file to COMPACTING until the end of task, so that it can be selected to participate in other task after this task finishes.