Skip to content

[IOTDB-5462] Optimize the memory estimation of ExchangeOperator in the pipeline#8970

Merged
JackieTien97 merged 6 commits intomasterfrom
lmh/exchangeMem
Feb 27, 2023
Merged

[IOTDB-5462] Optimize the memory estimation of ExchangeOperator in the pipeline#8970
JackieTien97 merged 6 commits intomasterfrom
lmh/exchangeMem

Conversation

@liuminghui233
Copy link
Copy Markdown
Member

@liuminghui233 liuminghui233 commented Feb 3, 2023 •
edited
Loading

For ExchangeOperator in pipeline, the maxReturnSize is equal to the maxReturnSize of the child operator.

JackieTien97

This comment was marked as duplicate.

Sign in to view

JackieTien97
JackieTien97 requested changes Feb 7, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@JackieTien97 JackieTien97 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as dealWithConsumeChildrenOneByOneNode and remember to add a UT about this.

@liuminghui233
Copy link
Copy Markdown
Member Author

liuminghui233 commented Feb 7, 2023

same as dealWithConsumeChildrenOneByOneNode and remember to add a UT about this.

UT added.
In the dealWithConsumeChildrenOneByOneNode method, ExchangeOperator is not added, so there is no need to modify it.

@liuminghui233
Merge remote-tracking branch 'origin/master' into lmh/exchangeMem
aa94bbd 
# Conflicts:
#	server/src/main/java/org/apache/iotdb/db/mpp/plan/planner/OperatorTreeGenerator.java
@liuminghui233
update
04d5fcc
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Feb 27, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@JackieTien97 JackieTien97 merged commit 12d9e73 into master Feb 27, 2023
@JackieTien97 JackieTien97 deleted the lmh/exchangeMem branch February 27, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JackieTien97 JackieTien97 JackieTien97 requested changes

@Alima777 Alima777 Alima777 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@liuminghui233 @JackieTien97 @Alima777