[IOTDB-5147]Optimize compaction schedule when priority is BALANCE#9103
Merged
xingtanzjr merged 4 commits intoapache:masterfrom Feb 24, 2023
Merged
[IOTDB-5147]Optimize compaction schedule when priority is BALANCE#9103xingtanzjr merged 4 commits intoapache:masterfrom
xingtanzjr merged 4 commits intoapache:masterfrom
Conversation
THUMarkLau
reviewed
Feb 21, 2023
| // submit a merge task even it does not meet the requirement for file num or file size | ||
| if (hasNextTimePartition && selectedFileList.size() > 1) { | ||
| taskPriorityQueue.add(new Pair<>(new ArrayList<>(selectedFileList), selectedFileSize)); | ||
| addOneTaskToQueue(taskPriorityQueue, selectedFileList, selectedFileSize); |
Contributor
There was a problem hiding this comment.
The return value is not used.
Contributor
Author
There was a problem hiding this comment.
It is unnecessary to use return value of addOneTaskToQueue here, because no matter what it is, selectLevelTask method will return false here.
| private boolean enableCompactionValidation = true; | ||
|
|
||
| /** The number of candidate compaction task queue. */ | ||
| private int candidateCompactionTaskQueueSize = 50; |
Contributor
There was a problem hiding this comment.
This param is appeared in IoTDBConfig but not in iotdb-common.properties.
THUMarkLau
requested changes
Feb 23, 2023
node-commons/src/assembly/resources/conf/iotdb-common.properties
Outdated
Show resolved
Hide resolved
xingtanzjr
force-pushed
the
CompactionComparator
branch
from
e6297d8 to
b7e8ed1
Compare
choubenson
force-pushed
the
CompactionComparator
branch
from
b7e8ed1 to
e6297d8
Compare
xingtanzjr
approved these changes
Feb 23, 2023
Contributor
|
Let's complete the verification of BALANCE for inner compaction between seq and unseq by Benchmark with 50% out-of-order data |
choubenson
added a commit
to choubenson/iotdb
that referenced
this pull request
Feb 28, 2023
…ache#9103) (cherry picked from commit a3869ec)
l2280212
pushed a commit
to l2280212/iotdb
that referenced
this pull request
Mar 5, 2023
This was referenced Mar 9, 2023
Closed
This was referenced Apr 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes in this pr are as follows:
candidateCompactionTaskQueuefrom 1000 to 50. The advantage is to avoid tasks blocked in the queue occupying files for a long time, resulting in no files being selected for cross-space compaction. But another impact is that once the number of files is large, because the number of tasks in the queue shrinks, the inner-space compaction will not be able to compact the latest files.