Skip to content

[IOTDB-5613] Remove unnecessary serialization in IoTConsensus when replicaNum is 1 to improve write performance#9204

Merged
SpriCoder merged 4 commits intomasterfrom
fix_single_replica_unnecessary_serialization
Mar 3, 2023
Merged

[IOTDB-5613] Remove unnecessary serialization in IoTConsensus when replicaNum is 1 to improve write performance#9204
SpriCoder merged 4 commits intomasterfrom
fix_single_replica_unnecessary_serialization

Conversation

@OneSizeFitsQuorum
Copy link
Contributor

@OneSizeFitsQuorum OneSizeFitsQuorum commented Mar 2, 2023

see jira

I tested with 1c1d on the machine and the throughput improved by 70%

Before:
image
After:
image

Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>
Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>
Copy link
Contributor

@THUMarkLau THUMarkLau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>
Copy link
Collaborator

@HxpSerein HxpSerein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 3, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@SpriCoder SpriCoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@SpriCoder SpriCoder merged commit 2557b1d into master Mar 3, 2023
@OneSizeFitsQuorum OneSizeFitsQuorum deleted the fix_single_replica_unnecessary_serialization branch March 3, 2023 15:27
OneSizeFitsQuorum added a commit that referenced this pull request Mar 4, 2023
…plicaNum is 1 to improve write performance (#9204)

* finish

Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>

* remove unused code

Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>

* add wal & UT buildSerializedRequest

Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>

* fix UT

Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>

---------

Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>
SpriCoder pushed a commit that referenced this pull request Mar 6, 2023
…plicaNum is 1 to improve write performance (#9204) (#9216)

* finish



* remove unused code



* add wal & UT buildSerializedRequest



* fix UT



---------

Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>
MarcosZyk pushed a commit that referenced this pull request Mar 7, 2023
…plicaNum is 1 to improve write performance (#9204) (#9216)

* finish



* remove unused code



* add wal & UT buildSerializedRequest



* fix UT



---------

Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants