Skip to content

[IOTDB-5654] Pipe SQL: From SQL to CN#9245

Merged
SteveYurongSu merged 14 commits intoapache:masterfrom
Caideyipi:check
Mar 10, 2023
Merged

[IOTDB-5654] Pipe SQL: From SQL to CN#9245
SteveYurongSu merged 14 commits intoapache:masterfrom
Caideyipi:check

Conversation

@Caideyipi
Copy link
Collaborator

@Caideyipi Caideyipi commented Mar 8, 2023 •
edited
Loading

IOTDB-5654

Pipe SQL: From SQL to CN
Implemented pipe SQLs and linked them to the confignode.

Implementations

Create Pipe SQL
Show Pipe SQL
According to the document: https://apache-iotdb.feishu.cn/docx/IbradDMLYoC0E2xwE9Jcdw4Onge

Deletions

Some old files contradicting to the new functions.
All the old IT's and procedure UT.

Test Images

image
image

This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.
Key changed/added classes (or packages if there are too many classes) in this PR

@SteveYurongSu SteveYurongSu self-requested a review March 8, 2023 13:37
SteveYurongSu
SteveYurongSu reviewed Mar 9, 2023
View reviewed changes
SteveYurongSu
SteveYurongSu reviewed Mar 9, 2023
View reviewed changes
SteveYurongSu
SteveYurongSu requested changes Mar 9, 2023
View reviewed changes
Copy link
Member

@SteveYurongSu SteveYurongSu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issues. PTAL :)

Caideyipi and others added 2 commits March 9, 2023 16:43
@Caideyipi @SteveYurongSu
Update server/src/main/java/org/apache/iotdb/db/mpp/plan/statement/sy…
643488a 
…s/sync/ShowPipeStatement.java

Co-authored-by: Steve Yurong Su <rong@apache.org>
@Caideyipi @SteveYurongSu
Update server/src/main/java/org/apache/iotdb/db/mpp/plan/execution/co…
6bc4a12 
…nfig/executor/ClusterConfigTaskExecutor.java

Co-authored-by: Steve Yurong Su <rong@apache.org>
@Caideyipi Caideyipi changed the title Pipe SQL: From SQL to CN [IOTDB-5654] Pipe SQL: From SQL to CN Mar 9, 2023
SteveYurongSu
SteveYurongSu approved these changes Mar 10, 2023
View reviewed changes
Copy link
Member

@SteveYurongSu SteveYurongSu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SteveYurongSu SteveYurongSu merged commit 94f05ad into apache:master Mar 10, 2023
This was referenced Mar 15, 2023
Merged
Merged
@CritasWang CritasWang mentioned this pull request Mar 24, 2023
Closed
@CritasWang CritasWang mentioned this pull request Apr 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveYurongSu SteveYurongSu SteveYurongSu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Caideyipi @SteveYurongSu