[IOTDB-5659] Fix dead lock condition in shutdown hook#9274
Merged
OneSizeFitsQuorum merged 1 commit intoapache:masterfrom Mar 10, 2023
Merged
[IOTDB-5659] Fix dead lock condition in shutdown hook#9274OneSizeFitsQuorum merged 1 commit intoapache:masterfrom
OneSizeFitsQuorum merged 1 commit intoapache:masterfrom
Conversation
OneSizeFitsQuorum
approved these changes
Mar 9, 2023
Contributor
OneSizeFitsQuorum
left a comment
OneSizeFitsQuorum
left a comment
There was a problem hiding this comment.
LGTM~
As ugly as I think this is, we really don't have a better idea right now, and hope that someone in the future will save us
This was referenced Mar 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current stop hook produces dead lock situations that prevent the process to terminate.
Ratis waits applyIndex to advance to commitIndex. However, it cannot be done when node is ReadOnly.