Skip to content

[To rel/1.1][IOTDB-5738] Retain 2 copies of snapshot#9475

Merged
OneSizeFitsQuorum merged 1 commit intoapache:rel/1.1from
SzyWilliam:cp-jira5738
Mar 29, 2023
Merged

[To rel/1.1][IOTDB-5738] Retain 2 copies of snapshot#9475
OneSizeFitsQuorum merged 1 commit intoapache:rel/1.1from
SzyWilliam:cp-jira5738

Conversation

@SzyWilliam
Copy link
Member

cherry pick of #9474


final int retainIndex =
snapshotRetentionPolicy.getNumSnapshotsRetained() - 1; // snapshot rank starts from 0
for (int i = retainIndex; i < sortedSnapshotDirs.length - 1; i++) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The modification code and master branch are different. why?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Now they are the same. Thanks!

Copy link
Member

@wangchao316 wangchao316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@OneSizeFitsQuorum OneSizeFitsQuorum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants