[IOTDB-5786] Fix potential deadlock in DriverScheduler#9640
Merged
JackieTien97 merged 2 commits intoapache:masterfrom Apr 19, 2023
Merged
[IOTDB-5786] Fix potential deadlock in DriverScheduler#9640JackieTien97 merged 2 commits intoapache:masterfrom
JackieTien97 merged 2 commits intoapache:masterfrom
Conversation
Alima777
reviewed
Apr 18, 2023
| } finally { | ||
| task.unlock(); | ||
| } | ||
| task.setAbortCause(DriverTaskAbortedException.BY_QUERY_CASCADING_ABORTED); |
Contributor
There was a problem hiding this comment.
There is a little problem. If we set abort cause without lock, the origin cause may be occupied.
Contributor
There was a problem hiding this comment.
Oh, even though we set it with lock, it can be occupied too. Maybe a status check is necessary, or just delete the abort cause, it seems we don't care it...
Contributor
Author
There was a problem hiding this comment.
Yes, it seems that the last write wins
Contributor
Author
There was a problem hiding this comment.
Oh, even though we set it with lock, it can be occupied too. Maybe a status check is necessary, or just delete the abort cause, it seems we don't care it...
For now we just need it not to be NULL
JackieTien97
approved these changes
Apr 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr aims to fix potential deadlock in DriverScheduler caused by concurrently calling abortFramentInstance and toAborted.
See https://apache-iotdb.feishu.cn/docx/KFsvdMwL4orqkCxrdARc37W8nxf for more details.