JCRVLT-485 Ignore mandatory protected properties from mix:versionable#110
Closed
stefanseifert wants to merge 1 commit intoapache:masterfrom
Closed
JCRVLT-485 Ignore mandatory protected properties from mix:versionable#110stefanseifert wants to merge 1 commit intoapache:masterfrom
stefanseifert wants to merge 1 commit intoapache:masterfrom
Conversation
kwin
reviewed
Dec 7, 2020
|
|
||
| private static final Collection<Name> ALLOWED_PROTECTED_PROPERTIES = Arrays.asList(NameConstants.JCR_PRIMARYTYPE, | ||
| NameConstants.JCR_MIXINTYPES); | ||
| // ignore mandatory protected properties from mix:versionable, they are handled specifically in filevault (JCRVLT-485) |
Member
There was a problem hiding this comment.
Probably we should exclude all properties listed in
from both the mandatory check as well as the protected check. WDYT?
Member
Author
There was a problem hiding this comment.
yes, i think this makes sense - updated the PR
…ies which are handled specially in filevault
stefanseifert
force-pushed
the
feature/JCRVLT-485-versioning-props-fix
branch
from
8d485a9 to
409ffd5
Compare
kwin
approved these changes
Dec 7, 2020
Member
|
I committed a slightly modified version in 0fa305d. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.