OAK-10328 fix scope of "jackrabbit-jcr-tests"#1005
Merged
Conversation
kwin
force-pushed
the
bugfix/fix-scope-of-jr-jcr-tests
branch
from
7917823 to
c020b36
Compare
mreutegg
reviewed
Jun 26, 2023
| <artifactId>jackrabbit-jcr-tests</artifactId> | ||
| <version>${jackrabbit.version}</version> | ||
| <scope>test</scope> | ||
| <optional>true</optional> |
Contributor
There was a problem hiding this comment.
And at the same time remove optional flag?
Member
Author
There was a problem hiding this comment.
Although not considered right now, I think the optional flag kind of indicates, that this is not supposed to be part of the Maven test compile classpath (but only necessary for executing some tests). Maven however does not support this kind of granularity (at least yet), but leaving the optional in does not do any harm, because there is some semantics behind that (not evaluated by Maven apart from having an impact as transitive dependency). I am fine with both leaving or removing, up to you to decide...
Contributor
There was a problem hiding this comment.
OK, then let's keep it for now.
mreutegg
approved these changes
Jun 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.