OAK-10365: introduce mapping version in elastic index definition #1035
Conversation
| return getOptionalValue(definition, PROP_INDEX_MAPPING_VERSION, "1.0.0"); | ||
| } |
There was a problem hiding this comment.
Shouldn't the default value be a clearly invalid version, like 0.0.0? Because we will assume that 1.0.0 is a valid version, so it can create confusion in cases where the index is missing a version, we might assume wrongly that it has a version.
There was a problem hiding this comment.
The mapping version is internal and cannot be changed in the index definition (it's stored in a hidden property). If the index definition does not have a version, we return the base version currently set as 1.0.0.
| @Test | ||
| public void indexStoresMappingVersion() throws Exception { | ||
| IndexDefinitionBuilder builder = createIndex("a").noAsync(); | ||
| builder.indexRule("nt:base").property("a").propertyIndex(); | ||
| Tree index = setIndex(UUID.randomUUID().toString(), builder); | ||
| root.commit(); | ||
|
|
||
| assertEventually(() -> assertEquals(ElasticIndexHelper.MAPPING_VERSION, | ||
| getElasticIndexDefinition(index).getMappingVersion())); | ||
| } |
There was a problem hiding this comment.
It is missing a test that sets the mapping version and checks that it returns the version that we set.
There was a problem hiding this comment.
As in the comment above, the version is internal and cannot be configured in the index definition. In this test we just need to test the mapping version gets stored and is equal to the current mapping version (ElasticIndexHelper.MAPPING_VERSION).
4 participants
No description provided.