OAK-10475 - Expose the Mongo client connection in MongoDocumentNodeStoreBuilderBase#1142
Merged
thomasmueller merged 2 commits intoapache:trunkfrom Oct 10, 2023
nfsantos:OAK-10475
Merged
OAK-10475 - Expose the Mongo client connection in MongoDocumentNodeStoreBuilderBase#1142thomasmueller merged 2 commits intoapache:trunkfrom nfsantos:OAK-10475
thomasmueller merged 2 commits intoapache:trunkfrom
nfsantos:OAK-10475
Conversation
| * @return the client or null if the {@link #setMongoDB(String, String, int)} method hasn't been called. | ||
| */ | ||
| public MongoClient getMongoClient() { | ||
| return mongoClient; |
Member
There was a problem hiding this comment.
This would make the mongoClient field obsolete:
Suggested change
| return mongoClient; | |
| return mongoDBConnection.getClient(); |
Contributor
Author
There was a problem hiding this comment.
The class is not keeping a reference to mongoDBConnection in a field. We could change it to keep mongoDBConnection in a field instead of the references to mongoClient for mongoDBConnection.getClient() and mongoStatus for mongoDBConnection.getStatus(), but this would create unnecessary coupling between MongoDocumentNodeStoreBuilderBase and MongoDBConnection. MongoDBConnection contains fields that are not needed by MongoDocumentNodeStoreBuilderBase. I would prefer to leave it as is.
thomasmueller
approved these changes
Oct 10, 2023
nit0906
pushed a commit
to nit0906/jackrabbit-oak
that referenced
this pull request
Oct 17, 2023
…ntNodeStoreBuilderBase (apache#1142)" This reverts commit 8ef2cf8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up of OAK-10453, which changed the indexing job to use custom codecs when downloading from Mongo. For this, the indexing logic needs access to the Mongo Connection to register the codec. If a library client uses MongoDocumentNodeStoreBuilderBase to build a MongoDocumentStore instance, then it may also need access to the Mongo connection to pass it to the indexing logic.