OAK-10584 : catch exception in getOldestRevisionToKeep when in read-o…#1251
Merged
rishabhdaim merged 3 commits intotrunkfrom Dec 18, 2023
Merged
OAK-10584 : catch exception in getOldestRevisionToKeep when in read-o…#1251rishabhdaim merged 3 commits intotrunkfrom
rishabhdaim merged 3 commits intotrunkfrom
Conversation
|
rishabhdaim
reviewed
Dec 14, 2023
| store.findAndUpdate(Collection.SETTINGS, op); | ||
| LOG.debug("Purged {} expired checkpoints", op.getChanges().size()); | ||
| } catch (UnsupportedOperationException uoe) { | ||
| LOG.info("getOldestRevisionToKeep : could not clean up expired checkpoints" |
Contributor
There was a problem hiding this comment.
It should be LOG.warn at least.
Contributor
Author
There was a problem hiding this comment.
Reason for info was that using this in read-only (eg via oak-run revisions info), this exception is likely met. In which case a warn would be confusing. I think we'd need to expose whether or not a DocumentStore is read-only somehow - without that we're left with catching this exception (which I agree is not nice)
rishabhdaim
approved these changes
Dec 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nly mode