OAK-11155: Allow using a custom segment loading strategy #1747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, `AbstractFileStore` loads segments from the tar files by calling its package-private `readSegmentUncached` method. This is too limiting when its user needs to customize the segment loading strategy. This PR allows the user of `AbstractFileStore` to customize the behavior of `readSegmentUncached` by adding a new `@FunctionalInterface` parameter, `SegmentLoader`. If not set explicitly by the caller, FileStoreBuilder uses an implementation of `SegmentLoader` which behaves the same way as it currently does, which makes this change backwards-compatible with existing code. Closes OAK-11155
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
AbstractFileStoreloads segments from the tar files by calling its package-privatereadSegmentUncachedmethod. This is too limiting when its user needs to customize the segment loading strategy.This PR allows the user of
AbstractFileStoreto customize the behavior ofreadSegmentUncachedby adding a new@FunctionalInterfaceparameter,SegmentLoader. If not set explicitly by the caller, FileStoreBuilder uses an implementation ofSegmentLoaderwhich behaves the same way as it currently does, which makes this change backwards-compatible with existing code.Closes OAK-11155