OAK-11285 - Check if paths used in included/excluded Paths are absolute and fail if they are not #1878
Conversation
| private static void checkPathsAreAbsolute(Iterable<String> paths, String pathType) { | ||
| for (String path : paths) { | ||
| if (!PathUtils.isAbsolute(path)) { | ||
| throw new IllegalStateException("Invalid path in " + pathType + " paths list: " + path + ". Paths must be absolute."); |
There was a problem hiding this comment.
would it be better to throw an IllegalArgumentException instead ?
There was a problem hiding this comment.
I agree it would be better, but the PathFilter constructor is already throwing IllegalStateException in a check it does in the constructor, so I prefer to keep it consistent and use the same exception.
|
Should we add a test case where one of the paths start with a space? On another note, I thought we trimmed those string values? |
One of the tests is already testing paths that start with space. Let me know if you think we should add more tests. |
|
Oh right my eyes must have deceived me. That one space character can be quite subtle, I can understand why someone might miss it |
4 participants
The
includedPathsandexcludedPathsin an index definition must be absolute. If they are not or if they start with a space, then the indexing job may fail or hang. This PR adds a check to thePathFilterconstructor to check that all paths are absolute and fail immediately if they are not.